Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search through fuzzy picker #1283

Closed
matoous opened this issue Dec 17, 2021 · 2 comments
Closed

Global search through fuzzy picker #1283

matoous opened this issue Dec 17, 2021 · 2 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-hard Call for participation: Experience needed to fix: Hard / a lot

Comments

@matoous
Copy link
Contributor

matoous commented Dec 17, 2021

Describe your feature request

Global search could be more useful (subjective opinion) if there were live results available. Would it make more sense for global search (space + /) to pop fuzzy finder the same way for example space + f does for files currently?

@matoous matoous added the C-enhancement Category: Improvements label Dec 17, 2021
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Dec 17, 2021
@pppKin
Copy link
Contributor

pppKin commented Jan 10, 2022

@archseer thought of this before, but ultimately it was just too troublesome(for me at least) to implement a special type of Picker and take care of the "search and update picker view" process. I'd love to help though now that I finally have some more time to work on helix! What do you have in mind?

edit: One straightforward way to implement this is to add a score_fn callback to Picker, so that everytime we type, we can start the search and feed the results back to Picker. However since global search is so expensive(can take seconds or even minutes), we'll need to integrate idle_timer in Picker. While we're at it, we should just somehow asynchronously feed the search results back to Picker, and provide a way to cancel the search midway. All of this, unfortunately, is not so easy to implement. We can start by waiting for idle_timer before Picker::score, though.

@pickfire pickfire added the E-hard Call for participation: Experience needed to fix: Hard / a lot label Jan 28, 2022
@archseer
Copy link
Member

Closing this as a duplicate of #196 (we made that the tracking issue now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-hard Call for participation: Experience needed to fix: Hard / a lot
Projects
None yet
Development

No branches or pull requests

5 participants