Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot input certain unicode characters on windows #8458

Closed
chtenb opened this issue Oct 3, 2023 · 16 comments
Closed

Cannot input certain unicode characters on windows #8458

chtenb opened this issue Oct 3, 2023 · 16 comments
Labels
C-bug Category: This is a bug O-windows Operating system: Windows upstream

Comments

@chtenb
Copy link
Contributor

chtenb commented Oct 3, 2023

Summary

It's impossible to input the πŸŽ‰ character into helix, either through pasting or directly inserting (using something like wincompose).
The character βœ… poses no problem however.

Reproduction Steps

Copy the πŸŽ‰ from here and try to paste it into helix using whatever method.

Helix log

The log contains no warnings

Platform

Windows

Terminal Emulator

Tried several, including WezTerm, Windows Terminal, cmd.exe

Helix Version

Custom build based on a recent commit

@chtenb chtenb added the C-bug Category: This is a bug label Oct 3, 2023
@chtenb
Copy link
Contributor Author

chtenb commented Oct 3, 2023

Possibly related issue due to shared dependencies: nushell/nushell#10578

@the-mikedavis
Copy link
Member

Looks like an issue upstream in crossterm as they say in the nushell issue

@the-mikedavis the-mikedavis added O-windows Operating system: Windows upstream labels Oct 3, 2023
@pascalkuthe
Copy link
Member

pascalkuthe commented Oct 3, 2023

yeah temrinal input (particuarly unicode) on windows is simply a mess and very hard to implement, there are other open issues about that (crossterm-rs/crossterm#820, #7129). i don't think the crossterm folks would work on this themselves.The windows input fixes were made by an outside contributor who doens't appear active on the repo.

I considered fixing crossterm-rs/crossterm#820, myself but I don't ever use windows and don't have access to a windows machine for testing (and don't care enough to setup a VM just for this).

@CptPotato
Copy link
Contributor

I considered fixing crossterm-rs/crossterm#820, myself but I don't ever use windows and don't have access to a windows machine for testing (and don't care enough to setup a VM just for this).

I'd be happy to test on windows, in case anyone decides to take this on.

@satorkain
Copy link

satorkain commented Oct 6, 2023

Works for me on win10. But only in WezTerm.

ΠΈΠ·ΠΎΠ±Ρ€Π°ΠΆΠ΅Π½ΠΈΠ΅

UPD
and in "windows-terminal"

ΠΈΠ·ΠΎΠ±Ρ€Π°ΠΆΠ΅Π½ΠΈΠ΅

@chtenb
Copy link
Contributor Author

chtenb commented Oct 7, 2023

Could it be that somehow you have a different conpty version? I don't really know how this all works, but I've read somewhere that some applications ship their own version of conpty while others depend on the system installed version.
FWIW I'm on windows 11.

@satorkain
Copy link

I don't know, I have the most stripped down build of win10 that doesn't have a store or even a calculator.

@kirawi
Copy link
Member

kirawi commented Oct 8, 2023

Wezterm packages a version of conpty with it. But this might be something else since it works in Windows Terminal.

@kirawi
Copy link
Member

kirawi commented Oct 9, 2023

I can replicate it on Windows 11 but not Windows 10.

@pascalkuthe
Copy link
Member

this likely should be reported against crossterm. They developed their windows handling against windows 10 I think.

@kirawi
Copy link
Member

kirawi commented Oct 9, 2023

I will. I also rechecked and I can actually replicate this in both 10 and 11. However, Alacritty on both versions works as expected compared to Windows Terminal and Wezterm.

@pascalkuthe
Copy link
Member

yeah wezterm uses a different API. I don't really know the ins and outs fo windows input handling but my understanding is that wezterm is the first terminal emulator besides windows terminal to use a certain API so its likely related to that API.

@kirawi
Copy link
Member

kirawi commented Oct 9, 2023

Two possibly related issues I found were microsoft/terminal#190 and PowerShell/PSReadLine#1329

@chtenb
Copy link
Contributor Author

chtenb commented Oct 10, 2023

this likely should be reported against crossterm. They developed their windows handling against windows 10 I think.

Should I create an issue in the crossterm issue tracker for this?

@chtenb
Copy link
Contributor Author

chtenb commented Apr 3, 2024

This issue does not reproduce anymore for me on the latest release on cmd.exe. Not sure if fixed by windows updates or crossterm updates.

@chtenb chtenb closed this as completed Apr 3, 2024
@chtenb
Copy link
Contributor Author

chtenb commented Apr 3, 2024

Still occurs on wezterm, I created wez/wezterm#5260 for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug O-windows Operating system: Windows upstream
Projects
None yet
Development

No branches or pull requests

6 participants