Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SDK request: Golang SDK for DropboxSign #313

Open
abhishekdas29 opened this issue Sep 21, 2023 · 3 comments
Open

New SDK request: Golang SDK for DropboxSign #313

abhishekdas29 opened this issue Sep 21, 2023 · 3 comments

Comments

@abhishekdas29
Copy link

Hello Team,

Do you have any plans for supporting the golang SDK generated from the OpenAPI specs?

I have a fork of the repo and have a draft PR to have it generated. I don't know if this is something which you want to bring in.
abhishekdas29#1

@jtreminio-dropbox
Copy link
Contributor

jtreminio-dropbox commented Oct 11, 2023

Unfortunately one of the hacky fixes we were forced to add to our OpenAPI spec was setting all endpoints as application/json first, and multipart/form-data second (if needed).

This is due to all the other generators creating completely different code depending on the request content type (multipart/form-data creating API methods where all arguments are listed, vs a single typed object).

This does not appear to be the case for the Golang generator, but I don't see that it correctly switches to multipart/form-data when a file upload is detected.

We would need to apply the same logic to this new Golang SDK to consider it.

edit: I'm not great with Golang, so apologies upfront if your PR already does the above!

@abhishekdas29
Copy link
Author

@jtreminio-dropbox - So are you saying that the auto generated files were manually overwritten in the PHP and node sdk?

@jtreminio-dropbox
Copy link
Contributor

jtreminio-dropbox commented Oct 16, 2023

Yes, all of our currently supported SDKs had their mustache templates changed to support what I listed above. I only linked PHP and Node but we did this for all the other languages as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants