Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes are not handled correctly #393

Closed
smerschjohann opened this issue May 29, 2024 · 1 comment · Fixed by #394
Closed

Quotes are not handled correctly #393

smerschjohann opened this issue May 29, 2024 · 1 comment · Fixed by #394

Comments

@smerschjohann
Copy link
Contributor

smerschjohann commented May 29, 2024

This change c946d99 is faulty and is a regression.

The testcase was valid and showed the error. But was wrongly removed.

The testcase checked that the string (quotes are part of the test): "ref+awsssm://srv/foo/bar?mode=singleparam", lead to the valid result: "awsssm-srv-/foo/bar"

But currently the result is (so a missing quote at the end): "awsssm-srv-/foo/bar

So the " is wrongly REMOVED at the end, which this test exactly checked.

This leads to issues in some situations, and is wrong behavior and worked before.

@smerschjohann
Copy link
Contributor Author

I fixed the regex again, hopefully it matches now everything as intended

@yxxhero yxxhero closed this as completed Jun 4, 2024
@yxxhero yxxhero linked a pull request Jun 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants