Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DNDarray.view() #689

Closed
ClaudiaComito opened this issue Oct 27, 2020 · 2 comments
Closed

Implement DNDarray.view() #689

ClaudiaComito opened this issue Oct 27, 2020 · 2 comments
Assignees
Labels
API Anything relating the API

Comments

@ClaudiaComito
Copy link
Contributor

[...] generally however I would obviously like to have something like a ht.view of the data, especially silent return of it. I am not 100% sure whether we can actually achieve this easily, due to the additional properties that we carry around and would have to watch out for. Yet, if somebody would successfully implement this, that would be a solid success for squeezing out further performance

Originally posted by @Markus-Goetz in #677 (comment)

@ClaudiaComito ClaudiaComito self-assigned this Oct 27, 2020
@ClaudiaComito
Copy link
Contributor Author

Also mentioned here #686

@ClaudiaComito ClaudiaComito changed the title Implement ht.view() Implement DNDarray.view() Nov 25, 2020
@ClaudiaComito ClaudiaComito mentioned this issue Nov 27, 2020
4 tasks
@ClaudiaComito ClaudiaComito added the API Anything relating the API label Apr 4, 2022
@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@ClaudiaComito ClaudiaComito removed this from the Repo Clean-Up milestone Aug 21, 2023
@ClaudiaComito
Copy link
Contributor Author

As of Aug 2023, we're already using torch views internally whenever possible (although we might still have some unnecessary copies in legacy code, they usually get addressed during refactoring).

So I'm not sure this issue still needs to be addressed. I'll close it for now, let me know if you think it should be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Anything relating the API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant