Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend wastime demo to support wasi32-wasi #595

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

stlankes
Copy link
Contributor

To support wasi, the PR start to the "wasi_snapshot_preview1". Cuurently, only the basic functions are supported, which are needed to run the fibonacci example.

In addition, the fibonacci example is converted from a library to a common application.

@stlankes stlankes requested a review from mkroening June 30, 2024 14:57
@stlankes stlankes force-pushed the wasmtime branch 4 times, most recently from caa1a2d to 7bf8634 Compare June 30, 2024 15:46
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall! :)

examples/wasmtime/Cargo.toml Outdated Show resolved Hide resolved
examples/wasmtime/src/preview1.rs Outdated Show resolved Hide resolved
examples/wasmtime/src/preview1.rs Outdated Show resolved Hide resolved
examples/wasmtime/src/main.rs Outdated Show resolved Hide resolved
@stlankes stlankes enabled auto-merge July 2, 2024 08:35
@stlankes stlankes disabled auto-merge July 2, 2024 08:58
@stlankes stlankes enabled auto-merge July 2, 2024 08:58
@stlankes
Copy link
Contributor Author

stlankes commented Jul 2, 2024

@mkroening I merge it because I fulfill all your requests.

To support wasi, the PR start to the "wasi_snapshot_preview1".
Cuurently, only the basic functions are supported, which are
needed to run the fibonacci example.

In addition, the fibonacci example is converted from a library
to a common application.
@stlankes stlankes added this pull request to the merge queue Jul 2, 2024
Merged via the queue into hermit-os:main with commit 5897f6a Jul 2, 2024
12 checks passed
@mkroening mkroening deleted the wasmtime branch July 2, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants