Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Firecracker versions 1.6.0 and up #1464

Closed
mkroening opened this issue Nov 19, 2024 · 0 comments · Fixed by #1466
Closed

Support Firecracker versions 1.6.0 and up #1464

mkroening opened this issue Nov 19, 2024 · 0 comments · Fixed by #1466
Assignees

Comments

@mkroening
Copy link
Member

mkroening commented Nov 19, 2024

Bisected with cherry-picked firecracker-microvm/firecracker@4e01ed8 gave firecracker-microvm/firecracker@b2a4081:

b2a40810174213d74f6470744e59f74031597195 is the first bad commit
commit b2a40810174213d74f6470744e59f74031597195
Author: Adam Jensen <adam@acj.sh>
Date:   Wed Dec 27 20:26:41 2023 +0000

    Populate the Entry Count field in MP configuration table
    
    Guest operating systems that comply with the Intel MP spec, such as
    FreeBSD, fail to boot because the Entry Count field in the
    MultiProcessor Configuration Table header is unset (defaults to 0).
    With the field set to a reasonable value, those guests are able to
    discover the MP configuration.
    
    Signed-off-by: Adam Jensen <adam@acj.sh>

 src/vmm/src/arch/x86_64/mptable.rs | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant