Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text less than 3 chars is not italicized #70

Closed
oohira opened this issue Nov 4, 2018 · 3 comments
Closed

text less than 3 chars is not italicized #70

oohira opened this issue Nov 4, 2018 · 3 comments

Comments

@oohira
Copy link

oohira commented Nov 4, 2018

It seems to be fixed in marked 0.4.0 (markedjs/marked#1181).

You can reproduce it by adding following code to hexo-renderer-marked/test/index.js.

it('should italicize 2 chars text correctly', function() {
  r({text: '*AND*'}).should.eql('<p><em>AND</em></p>\n');  // => PASS
  r({text: '_AND_'}).should.eql('<p><em>AND</em></p>\n');  // => PASS
  r({text: '*OK*'}).should.eql('<p><em>OK</em></p>\n');    // => PASS
  r({text: '_OK_'}).should.eql('<p><em>OK</em></p>\n');    // => FAILED
});
@yoshinorin
Copy link
Member

Thank you for your report !

I confirmed this issue. I updated marked to 0.5.1 and it will be solved. But, other tests were failed instead.
I will check other marked changes between current using version and 0.5.1.

Please wait...

@yoshinorin
Copy link
Member

@oohira
We released v1.0.0.
This issue probably already been resolved. Please check it.

Thanks :)

@oohira
Copy link
Author

oohira commented May 25, 2019

@yoshinorin Thanks for your great effort. I confirmed the issue was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants