fix(responsetranslator): review generic replacement logic

src/ResponseTranslator.php

@@ -65,7 +65,10 @@ public static function translate($raw, $cmd, $ph = [])
 
         // generic API response description rewrite
         foreach (self::$descriptionRegexMap as $regex => $val) {
-            $qregex = "/description=" . preg_quote($regex) . "/i";
+            // match the response for given description
+            // NOTE: we match if the description starts with the given description
+            // it would also match if it is followed by additional text
+            $qregex = "/description=" . preg_quote($regex) . "[^\r]*/i";
             if (preg_match($qregex, $newraw)) {
                 // replace command place holder with API command name used
                 if (isset($cmd["COMMAND"])) {

tests/ResponseTranslatorTest.php

@@ -134,6 +134,11 @@ public function testCheckDomainTransferTranslation(): void
         $this->assertEquals(219, $r->getCode());
         $this->assertEquals("The given Authorization Code is wrong. Initiating a Transfer is therefore impossible.", $r->getDescription());
 
+        // mixed status `locked` and Wrong Auth
+        $r = new R("[RESPONSE]\r\ncode=219\r\ndescription=Request is not available; DOMAIN TRANSFER IS PROHIBITED BY STATUS (clientTransferProhibited)/WRONG AUTH\r\nEOF\r\n", $cmd);
+        $this->assertEquals(219, $r->getCode());
+        $this->assertEquals("This Domain is locked. Initiating a Transfer is therefore impossible.", $r->getDescription());
+
         // Age of the Domain <= 60d
         $r = new R("[RESPONSE]\r\ncode=219\r\ndescription=Request is not available; DOMAIN TRANSFER IS PROHIBITED BY AGE OF THE DOMAIN\r\nEOF\r\n", $cmd);
         $this->assertEquals(219, $r->getCode());