Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo: Remove aliases that are "also works with" not true aliases #3049

Closed
6 tasks done
joshgoebel opened this issue Mar 17, 2021 · 2 comments
Closed
6 tasks done

Todo: Remove aliases that are "also works with" not true aliases #3049

joshgoebel opened this issue Mar 17, 2021 · 2 comments
Assignees
Labels
enhancement An enhancement or new feature
Milestone

Comments

@joshgoebel
Copy link
Member

joshgoebel commented Mar 17, 2021

Ref: #3035

This includes things like zsh for bash (we list no other shells) and aliasing all the many Lisp/Scheme implementations out there back to our Lisp/Scheme grammar. This is a something for implementors to do if they would prefer these aliases.

Remove:

  • zsh
  • mysql, oracle
  • 'freepascal',
  • 'lazarus',
  • 'lpr', (lazarus extension)
  • 'lfm' (lazarus extension)
@joshgoebel joshgoebel added the enhancement An enhancement or new feature label Mar 17, 2021
@joshgoebel joshgoebel added this to the 11.0 milestone Mar 17, 2021
@joshgoebel
Copy link
Member Author

Copying over the key part of my response from the other thread.


Are you aware of us doing something similar with any of our other aliases (perhaps we do)? If so then perhaps it's time we reviewed the entire policy around this (with v11 around the corner) vs dealing with this as a one-off.

I don't think we do this as a rule, the closest I found:

  • zsh for bash
  • mysql and oracle for sql_more (but this whole grammar is known to be problematic and it's on the way out)

I think bash is the closest comparison, and I think zsh as an alias is wrong there also - and should be removed. We specifically detect 10 or so different shells inside bash, yet we don't have 10 aliases - nor should we. Someone can specify sh to indicate shell script, or manually register aliases themselves. And while we do kind of acknowledge that bash is perhaps a bit general - we're also not beholden to support every shell's idiosyncrasies - leaving it bash helps make that clear.

In general I feel this is an anti-pattern and recommend we remove zsh from bash with version 11.


Oops, missed Delpi... I think we should consider removing:

  • 'freepascal',
  • 'lazarus',
  • 'lpr', (lazarus extension)
  • 'lfm' (lazarus extension)

Leaving only Delphi (the actual grammar) and Pascal variants. Pascal because it's the "original" language... Lazarus and FreePascal and simply variants of Pascal and shouldn't be directly aliased by Delphi.

XML is a little crazy also, but I also feel there is no obligation created there since all the listed formats are 100% XML by the very nature of XML. So they bother me less and I'm not sure they are in the same category.

    aliases: [
      'html',
      'xhtml',
      'rss',
      'atom',
      'xjb',
      'xsd',
      'xsl',
      'plist',
      'wsf',
      'svg'
    ],

@joshgoebel joshgoebel self-assigned this Mar 17, 2021
@joshgoebel joshgoebel mentioned this issue Mar 17, 2021
25 tasks
@joshgoebel
Copy link
Member Author

Closed in version_11 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature
Projects
None yet
Development

No branches or pull requests

1 participant