Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow OpenTelemetry convention #1

Closed
gitmalong opened this issue Feb 5, 2023 · 3 comments
Closed

Follow OpenTelemetry convention #1

gitmalong opened this issue Feb 5, 2023 · 3 comments

Comments

@gitmalong
Copy link

According to your docs expanded code example I could not see that sql statements are packed into the db.statement field. Would be great if those conventions can be followed upon:

https://opentelemetry.io/docs/reference/specification/trace/semantic_conventions/database/

@hinohi
Copy link
Owner

hinohi commented Feb 6, 2023

Thanks for telling me.
I will change the implementation to conform to the official specifications as much as possible.

@gitmalong
Copy link
Author

There is also an open PR at the sqlx crate to implement tracing directly into there. launchbadge/sqlx#2185 (comment)

@hinohi
Copy link
Owner

hinohi commented Nov 13, 2023

  • otel spec に対応して db.statementcode.lineno を利用するようにしました
  • sqlx の tracing は log のみであり、引き続きこのライブラリは有用なようです

@hinohi hinohi closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants