-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cache handlers for individual items (blocks, microblocks, principals) #1230
Comments
@rafaelcr Can this be closed? The cached/uncached percentage has been improving the last several months, at ~75% now. |
@smcclellan we should probably icebox this one. it's a good improvement that we should make at some point. |
🎉 This issue has been resolved in version 8.1.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We currently have two cache handlers that we use to create ETags for most of our endpoints:
tx_id
sWhile these work great for endpoints which depend on global chain or mempool status like
/extended/v1/blocks
or/extended/v1/tx/mempool
, they can incorrectly return a cache miss for others that are concerned with individual items. Some examples:/extended/v1/blocks/:block_hash
would be a cache miss when the chain advances, even though the individual block would not have changed at all/extended/v1/tx/:tx_id
similar (but already being fixed in feat: add cache control to/extended/v1/tx/:tx_id
#1229)/extended/v1/address/:principal/transactions
would be a cache miss even though that principal did not receive or send any new transactions/extended/v1/address/:principal/balances
same as aboveWe should create an individual item cache handlers for each of these (and more) use cases so we can maximize our number of cached responses
The text was updated successfully, but these errors were encountered: