fix: differentiate mempool transactions when calculating principal etag #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-1j1co05gd-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
zone117x
approved these changes
Oct 18, 2024
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 18, 2024
## [8.1.1](v8.1.0...v8.1.1) (2024-10-18) ### Bug Fixes * identify mempool transactions separately when calculating principal etag ([#2126](#2126)) ([b9dee2a](b9dee2a))
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a mempool balance did not convert to confirmed balance due to a duplicate Etag calculation. This was because we were taking all the latest
tx_ids that affected an account (both confirmed and mempool) to calculate the Etag, but when a mempool tx becomes confirmed the Etag did not change because that transaction retains the same transaction ID.The solution is to prepend a string such as
mempool-to a mempool transaction ID so the Etag will change once that transaction confirms.