Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosetta): add support for Nakamoto coinbase for unlock events #2162

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

obycode
Copy link
Member

@obycode obycode commented Nov 10, 2024

Description

Add support for Nakamoto coinbase when handling unlock events. This addresses an error reported by users with the first new reward cycle in Nakamoto. The change adds a check for this new third kind of coinbase in the SQL query.

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No

Are documentation updates required?

No

Testing information

Provide context on how tests should be performed.

  1. Is testing required for this change?
  2. If it’s a bug fix, list steps to reproduce the bug
  3. Briefly mention affected code paths
  4. List other affected projects if possible
  5. Things to watch out for when testing

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @rafaelcr or @zone117x for review

Copy link

Vercel deployment URL: https://stacks-blockchain-jux52o1j7-hirosystems.vercel.app 🚀

@obycode obycode requested a review from zone117x November 10, 2024 21:16
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rafaelcr rafaelcr changed the title fix: add support for Nakamoto coinbase for unlock events fix(rosetta): add support for Nakamoto coinbase for unlock events Nov 10, 2024
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you switch the base branch to master so it generates a hotfix release? Thanks @obycode !

@rafaelcr rafaelcr changed the base branch from develop to master November 10, 2024 22:22
@rafaelcr rafaelcr merged commit 2370799 into master Nov 10, 2024
28 checks passed
@rafaelcr rafaelcr deleted the fix/nakamoto-coinbase branch November 10, 2024 22:23
blockstack-devops pushed a commit that referenced this pull request Nov 10, 2024
## [8.2.2](v8.2.1...v8.2.2) (2024-11-10)

### Bug Fixes

* **rosetta:** add support for Nakamoto coinbase for unlock events ([#2162](#2162)) ([2370799](2370799))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants