problems when dooms themes work with org-mode and neotree

[ethanyu336]

1. org-mode "" heading with linum-relative has a problem that a little part of "0" is covered by ""
2. with doom-neotree, last char of the root dir's name doesnt display.
   here is the pic
   

anyway,i love the doom-themes, thanks for your effort.

[ethanyu336]

It's very strange,
if i use "neotree-dir" command to open folder,
the second problem doesnt appear

[hlissner]

I've added a fix for the second issue. Let me know if it still occurs.

The linum-relative issue is an odd one. I've just pushed a few updates to line number faces, could you update and see if it fixed your issue?

[ethanyu336]

Yeah.Second issue is fixed. Good work!
The first one issue still exists.

[ryankask]

The ellipsis is not rendering for me. Sometimes it does, however, and it appears like the unfilled rectangle at the top right of your screenshot.

Do you know what this is or how I can have a normal ellipsis?

[xiaoxinghu]

I also have the ellipsis problem, I am using emacs-mac.

[xiaoxinghu]

@ryankask In case you are looking for a temporary solution (it drives me nuts looking like that), set the org-ellipsis to nil. It will go back to ....

[ryankask]

Thanks, @xiaoxinghu. I made this change last week because aside from the strange appearance, it felt really slow while editing. emacs actually crashed once when opening an org file.

I'm using macOS but I'm not sure what's going on.

[partnano]

I am also encountering the ellipsis problem, running Emacs 25.2 on Manjaro Linux
The suggested fix (setting the variable to nil) works, but it would be amazing if we could use a custom ellipsis with the theme

[hlissner]

doom-themes only changed the default and shouldn't stop you from changing it with (setq org-ellipsis " ... "). Perhaps some of you are changing it before the theme is loaded, which gets overwritten when the theme is later loaded?

In any case, I've removed this from doom-themes. Let me know if that resolves your issues.

[hlissner]

@ichirika Sorry for the long wait. You can fix problem #1 by either disabling the differently sized org headers, like so:

(set-face-attribute 'org-level-1 nil :height 1.0)

Or by explicitly setting an absolute :height for linum and linum-relative's faces:

(let ((height (face-attribute 'default :height)))
  (set-face-attribute 'linum nil :height height)
  (set-face-attribute 'linum-relative-current-face nil :height height))

Unfortunately, this is a natural limitation of overlays, which linum (and nlinum) use to display line numbers. I can't put a :height on line numbers because this causes other breakages (e.g. with text-scale), so I'm afraid you'll have to use the above. I'll add them in the readme for other linum/nlinum users. Issues like these should disappear once we get to Emacs 26, which has line numbers built in.

Problem #2 should have been resolved since fb92c7c, so I'll close this issue. Feel free to reopen if my suggestions above didn't help.