Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie.maxAge doesnt work #280

Closed
ghost opened this issue Sep 11, 2020 · 1 comment
Closed

cookie.maxAge doesnt work #280

ghost opened this issue Sep 11, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 11, 2020

I have set cookie.maxAge to 30 days (2592000s) and it used to work (@3.2.3). But it stopped working recently after updating to the latest version (@3.3.1). I was looking at this line of the code and was wondering if this should be req.session.cookie.expires instead? Thanks.
@hoangvvo
Copy link
Owner

Hey, sorry for the trouble. It is correct, thank you! Fixed in 3.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hoangvvo