Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite tests #38

Closed
hoangvvo opened this issue Oct 16, 2019 · 0 comments · Fixed by #45
Closed

Rewrite tests #38

hoangvvo opened this issue Oct 16, 2019 · 0 comments · Fixed by #45
Assignees
@hoangvvo
Labels
enhancement Improvement to existed feature

Comments

@hoangvvo
Copy link
Owner

May close #37 in favor of this.

The way next-session is tested is not ideal since it has a lot of monkey-patching. Furthurmore, the only read thing that is tested is withSession() - useSession() is not well tested.
This was referenced Oct 16, 2019
Merged
Merged
@hoangvvo hoangvvo self-assigned this Oct 16, 2019
@hoangvvo hoangvvo added the enhancement Improvement to existed feature label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoangvvo hoangvvo

Labels
enhancement Improvement to existed feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve test coverage hoangvvo/next-session
1 participant
@hoangvvo