Web page shows generic error message if you try to add a duplicate bookmark

[skirmess]

Trying to add a bookmark, which already exists, from the web page shows this error message:

The server log shows:

web-1          | s [TRPCError]: Bookmark e8kgxwkflas1hw75h92v7303 is already in the list saq2f0uqazppijovqcqbezj8
web-1          |     at /app/apps/web/.next/server/chunks/838.js:1:20346
web-1          |     at async c.middlewares (/app/apps/web/.next/server/chunks/673.js:4823:10163)
web-1          |     at async a (/app/apps/web/.next/server/chunks/673.js:4823:9557)
web-1          |     at async a (/app/apps/web/.next/server/chunks/673.js:4823:9557)
web-1          |     at async a (/app/apps/web/.next/server/chunks/673.js:4823:9557)
web-1          |     at async a (/app/apps/web/.next/server/chunks/673.js:4823:9557)
web-1          |     at async a (/app/apps/web/.next/server/chunks/673.js:4823:9557)
web-1          |     at async a (/app/apps/web/.next/server/chunks/673.js:4823:9557)
web-1          |     at async t (/app/apps/web/.next/server/chunks/673.js:4823:9896)
web-1          |     at async /app/apps/web/.next/server/app/api/trpc/[trpc]/route.js:1:4281 {
web-1          |   code: 'BAD_REQUEST',
web-1          |   [cause]: undefined

Ideally, the web page should mention the reason why the bookmark wasn't added.

[kamtschatka]

are you using the latest version? (0.14) You can check on the admin page.
That has link deduplication and should look like this:

If yes, how did you add it?

[skirmess]

Yes, I'm using 0.14.0.

Steps to reproduce:

• Click on Home
• Create a bookmark, e.g.: https://duckduckgo.com/

The bookmark is added

• Create a new list, e.g.: test list

• In the list, add the bookmark
  

• You get the message you mentioned and the existing bookmark is added to this list (this is awesome!!!)
  

• Now try to add the bookmark again to the list and you get my error message:

[kamtschatka]

It is quite technical, but still understandable I would say? At this point of the code we only have the id of the bookmark and the id of the list, so this is the best we can get, without doing another query on the database to provide more information.

[skirmess]

I guess you could also just say "Bookmark is already in this list". This would only show when you try to add a bookmark to a specific list and it exists already in this list. You already know which list - the one you try to add it to.

[kamtschatka]

I also considered that, but there is now also multi url import, so it might become a bit confusing if you try to add multiple bookmarks and you only get 10 messages with "Bookmark is already in this list".
Maybe "bookmark is already in this list"?

[skirmess]

I'm also fine with the cryptic message. :-) It does show that the issue is the user and not the software. :-)