Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing 2D elements with Annotators throws js error #4340

Closed
kcpevey opened this issue Mar 30, 2020 · 3 comments · Fixed by #4341
Closed

Drawing 2D elements with Annotators throws js error #4340

kcpevey opened this issue Mar 30, 2020 · 3 comments · Fixed by #4341

Comments

@kcpevey
Copy link
Collaborator

kcpevey commented Mar 30, 2020

ALL software version info

bokeh 2.0.0
holoview 1.13.1
panel 0.9.3

Description of expected behavior and the observed behavior

As soon as you start to draw a polygon, and with every new vertex, a js error is thrown. Once polygons are drawn on the screen, the table highlighting does not work.

I've also noticed this with hv.Path and hv.Rectangles, but hv.Point works properly.

Complete, minimal, self-contained example code that reproduces the issue

poly_annotate = hv.annotate.instance()
poly_layout = poly_annotate(hv.Polygons([]), annotations=['Label'])
poly_layout

Stack traceback and/or browser JavaScript console output

Uncaught ReferenceError: i is not defined
    at p.eval (eval at get func (lab:451), <anonymous>:20:12)
    at i.execute (<anonymous>:451:469)
    at p.<anonymous> (<anonymous>:337:1526)
    at o.emit (<anonymous>:276:662)
    at o.emit (<anonymous>:276:747)
    at d._emit_cds_changes (<anonymous>:625:966)
    at d._draw (<anonymous>:629:1189)
    at d._doubletap (<anonymous>:629:1741)
    at d.<anonymous> (<anonymous>:571:2920)
    at d.<anonymous> (<anonymous>:333:438)
@kcpevey
Copy link
Collaborator Author

kcpevey commented Mar 30, 2020

Also, I'd like to be more helpful when reporting/debugging things like this, but I don't know any js. Would it be possible for you to quickly explain how to follow the js traceback back to the package code? Or is that something that can't be described concisely?

@kcpevey
Copy link
Collaborator Author

kcpevey commented Mar 31, 2020

Confirmed this works on master. Thanks!

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant