From 8df5276ae35db04bcf9016edcfb1045086991d8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20H=C3=B8xbro=20Hansen?= Date: Sat, 16 Dec 2023 11:24:38 +0100 Subject: [PATCH 1/2] Update links and instructions in readme --- README.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index b70ff28ccc..7aee1728f1 100644 --- a/README.md +++ b/README.md @@ -59,16 +59,16 @@ Installation ============ HoloViews works with -[Python 3](https://github.com/holoviz/holoviews/actions?query=workflow%3Apytest) +[Python](https://github.com/holoviz/holoviews/actions/workflows/test.yaml) on Linux, Windows, or Mac, and works seamlessly with [Jupyter Notebook and JupyterLab](https://jupyter.org). The recommended way to install HoloViews is using the [conda](https://docs.conda.io/projects/conda/en/latest/index.html) command provided by -[Anaconda](https://docs.anaconda.com/anaconda/install/) or +[Anaconda](https://docs.anaconda.com/free/anaconda/install/) or [Miniconda](https://docs.conda.io/en/latest/miniconda.html): - conda install -c pyviz holoviews bokeh + conda install holoviews This command will install the typical packages most useful with HoloViews, though HoloViews itself depends only on @@ -96,14 +96,9 @@ Now you can launch Jupyter Notebook or JupyterLab to explore them: jupyter lab -If you are working with a JupyterLab version <2.0 you will also need the PyViz JupyterLab -extension: - - jupyter labextension install @pyviz/jupyterlab_pyviz - For more details on setup and configuration see [our website](https://holoviews.org/user_guide/Installing_and_Configuring.html). -For general discussion, we have a [gitter channel](https://gitter.im/pyviz/pyviz). +For general discussion, we have a [discord channel](https://discord.gg/AXRHnJU6sP). If you find any bugs or have any feature suggestions please file a GitHub [issue](https://github.com/holoviz/holoviews/issues) or submit a [pull request](https://help.github.com/articles/about-pull-requests). From 1ef3bece4cedccb5f05dabf739dad316418664db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20H=C3=B8xbro=20Hansen?= Date: Sat, 16 Dec 2023 12:54:54 +0100 Subject: [PATCH 2/2] Fix missing needs.changes.outputs.code == 'true' --- .github/workflows/test.yaml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index ccdcd0b808..9d5de5265c 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -136,10 +136,6 @@ jobs: cache: true playwright: true id: install - - name: doit env_capture - run: | - conda activate test-environment - doit env_capture - name: doit test_ui if: needs.changes.outputs.code == 'true' run: | @@ -180,6 +176,7 @@ jobs: # conda-update: true # id: install - uses: actions/checkout@v3 + if: needs.changes.outputs.code == 'true' with: fetch-depth: "100" - name: Fetch unshallow @@ -189,7 +186,9 @@ jobs: if: needs.changes.outputs.code == 'true' with: python-version: 3.12 - - run: | + - name: install + if: needs.changes.outputs.code == 'true' + run: | python -m pip install -ve '.[tests_core, tests_ci]' - name: bokeh sampledata if: needs.changes.outputs.code == 'true'