Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entrypoint for xarray #392

Closed
andersy005 opened this issue Dec 19, 2019 · 3 comments
Closed

Add entrypoint for xarray #392

andersy005 opened this issue Dec 19, 2019 · 3 comments

Comments

@andersy005
Copy link

Xarray is in the process of adding entrypoints for plotting backends in pydata/xarray#3640. I took a look at #319 which added entrypoint support for Pandas, and I noticed that .plot method is for Tabular data only:

@with_hv_extension
def plot(data, kind, **kwargs):
# drop reuse_plot

return hvPlotTabular(data)(kind=kind, **no_none_kwargs)

What's the right path to adding the entrypoint for Xarray in hvplot? Should the .plot method in hvplot/plotting/__init__.py be
extended/generalized in order to return instances of hvPlot class instead of hvPlotTabular?

With some guidance, I am happy to submit a PR that addresses this issue 😃

@philippjfr
Copy link
Member

Thanks for working on this! Very happy to see it. I think we'll probably want a separate plot method just for xarray. I'm not entirely sure how to structure that yet. @jsignell do you have any good ideas?

@jsignell
Copy link
Member

jsignell commented Feb 3, 2020

Sorry it took me so long to respond. Yes, a separate plot method is preferable.

@maximlt
Copy link
Member

maximlt commented Oct 18, 2022

xarray has not implemented support for that.

@maximlt maximlt closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants