-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended parser to support pyct commands #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Added docstring to main function Co-Authored-By: jlstevens <jlrstevens@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 90.07% 89.92% -0.15%
==========================================
Files 30 30
Lines 4746 4755 +9
==========================================
+ Hits 4275 4276 +1
- Misses 471 479 +8
Continue to review full report at Codecov.
|
bokeh_entry_point() | ||
def main(args=None): | ||
"""Special case: Allow Bokeh to handle the `serve` command; rest is handled by pyct.""" | ||
if len(sys.argv) > 1 and 'serve' == sys.argv[1]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 'serve' the only bokeh command we are supporting?
I'll merge, I'm not sure if we should support any bokeh commands other than |
The commands currently offered by Bokeh are:
I'm happy to be corrected, but I don't think there is any use for |
Addresses #109. It isn't obvious how to do the right thing here but this seems to me like the easiest way to splice together two external parsers. It does mean if you mistype 'serve', then it is the pyct parser that will complain.