-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template assets not loaded when running panel application via jupyter-server-proxy #1821
Comments
@AjayThorve I think this is coming from line 24 in I can confirm that changing line 450 to use the CDN_DIST instead of Just need to figure out how to pass the appropriate path through ... |
This is pretty high priority to fix. I wonder if there's a way to expose the static resources on the proxy, otherwise we will need some way of detecting when we're serving off the proxy. |
Is there a way to take
What I have noticed is changing the Not sure though if adding the extra |
I am not familiar enough with bokeh but I think this is how they are doing it?? @staticmethod
def _inline(path):
begin = "/* BEGIN %s */" % basename(path)
with open(path, "rb") as f:
middle = f.read().decode("utf-8")
end = "/* END %s */" % basename(path)
return "%s\n%s\n%s" % (begin, middle, end) Then again I could be completely wrong ... |
@WesleyTheGeolien Thanks for that, I'll play with this today. |
Made a start which handles most of the resources, still have to solve it for the template resources though. |
@philippjfr let me know if you want a hand testing this ... looks like you are making great progress though 👍 |
Description of expected behavior and the observed behavior
Running the react template app example, but via jupyter-server-proxy fails to load assets (css and js) resulting in a black screen:
Complete, minimal, self-contained example code that reproduces the issue
visit url
localhost:8888/proxy/{port}
Stack traceback and/or browser JavaScript console output
If you notice the url bootstrap.css is trying to load, its
localhost:8888/static
instead oflocalhost:8888/proxy/{port}/static
, which infact is the correct url.Also, other resources like
bokeh
andpanel.min.js
are infact loaded correctly usinglocalhost:8888/proxy/{port}
as the baseExpected Behavior
All assets are loaded similar to the scenario when we run it without jupyter-server-proxy.
ALL software version info
bokeh: 2.2.3
panel: 0.10.2
cc @bryevdv @philippjfr
The text was updated successfully, but these errors were encountered: