Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK] Implement Glyph3Dmapper serialization #2002

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Conversation

xavArtley
Copy link
Collaborator

fix: #2001

image

@philippjfr
Copy link
Member

Thanks @xavArtley! Just one error in the unit tests:

>               getattr(instance, method)(*args)
E               TypeError: SetInputData() takes exactly 1 argument (2 given)

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #2002 (4882b26) into master (2b33b05) will decrease coverage by 0.01%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2002      +/-   ##
==========================================
- Coverage   84.58%   84.57%   -0.02%     
==========================================
  Files         164      164              
  Lines       19823    19833      +10     
==========================================
+ Hits        16768    16773       +5     
- Misses       3055     3060       +5     
Impacted Files Coverage Δ
panel/pane/vtk/synchronizable_serializer.py 79.93% <68.42%> (-0.91%) ⬇️
panel/pane/vtk/synchronizable_deserializer.py 97.54% <100.00%> (+0.04%) ⬆️
panel/io/reload.py 68.23% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b33b05...4882b26. Read the comment docs.

@philippjfr philippjfr added this to the v0.11.0 milestone Feb 24, 2021
@philippjfr
Copy link
Member

Thanks, merging.

@philippjfr philippjfr merged commit fd9e09c into master Feb 24, 2021
@philippjfr philippjfr deleted the xav/vtk_glyph3dmapper branch February 24, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtkGlyph3DMapper on Panel + JupyterLab gives javascript error, blank screen
2 participants