Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure GridSpec override handles duplicate matches #2150

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

philippjfr
Copy link
Member

The GridSpec override logic matched overlaps for each cell which meant that the same item could be recorded for deletion multiple times which could fail. We now deduplicate the matches using a set operation and to be sure made the deletion robust to a KeyError.

Fixes #2106

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #2150 (cf4cebe) into master (56ce69c) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2150      +/-   ##
==========================================
- Coverage   83.81%   83.77%   -0.05%     
==========================================
  Files         182      182              
  Lines       21672    21675       +3     
==========================================
- Hits        18165    18158       -7     
- Misses       3507     3517      +10     
Impacted Files Coverage Δ
panel/layout/grid.py 75.07% <71.42%> (-0.38%) ⬇️
panel/tests/pane/test_base.py 88.23% <0.00%> (-11.77%) ⬇️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️
panel/pane/base.py 87.89% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ce69c...cf4cebe. Read the comment docs.

@philippjfr philippjfr merged commit 0e20248 into master Apr 8, 2021
@philippjfr philippjfr deleted the gridspec_override_keyerror branch April 8, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError when setting gridspec content
1 participant