Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix videostream unpause #2508

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix videostream unpause #2508

merged 1 commit into from
Jul 8, 2021

Conversation

MarcSkovMadsen
Copy link
Collaborator

Fixes https://discourse.holoviz.org/t/videostream-does-not-show-video-after-setting-paused-to-false/2525.

I.e. you can pause and the un-pause again.

videostream-works.mp4
import panel as pn
import time
pn.extension()
video = pn.widgets.VideoStream(timeout=100, paused=False)

pn.Column(video, video.param.paused).servable()

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #2508 (ff4da35) into master (5d04322) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2508   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files         184      184           
  Lines       22723    22723           
=======================================
+ Hits        18859    18860    +1     
+ Misses       3864     3863    -1     
Impacted Files Coverage Δ
panel/tests/pane/test_plotly.py 98.63% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d04322...ff4da35. Read the comment docs.

@philippjfr philippjfr merged commit dc0b778 into master Jul 8, 2021
@philippjfr philippjfr deleted the videostream-unpause branch July 8, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants