-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hierarchical aggregation for Tabulator #2624
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2624 +/- ##
=======================================
Coverage 83.09% 83.09%
=======================================
Files 184 184
Lines 23295 23309 +14
=======================================
+ Hits 19356 19369 +13
- Misses 3939 3940 +1
Continue to review full report at Codecov.
|
panel/models/tabulator.ts
Outdated
const formatted = column.formatter.doFormat(cell.getRow(), cell, cell.getValue(), null, null) | ||
const node = div() | ||
node.innerHTML = formatted | ||
return node.children[0].innerHTML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This completely breaks HTMLTemplateFormatter
:
pn.widgets.Tabulator(pd.DataFrame({'link': ['foo']}),
formatters={'link': HTMLTemplateFormatter(
template='<a href="<%= value %>">Link</a>'
)})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you open an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, #2730
Fixes #2619