-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using a 4 tuple of min, max, step, value for interact #334
Conversation
Looks good to me. Ready to merge? |
I was adding a cell to the interact notebook. Think it's necessary? |
Yes, please do, because this is functionality beyond what ipywidgets supports and thus won't be expected by many people. |
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 89.42% 89.47% +0.05%
==========================================
Files 85 85
Lines 6828 6872 +44
==========================================
+ Hits 6106 6149 +43
- Misses 722 723 +1
Continue to review full report at Codecov.
|
I'm ready for this to go in now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks good. I assume it's deliberate to remove the jupyter-widgets state from Interact.ipynb? Nice to get all that out of there, as long as it's not needed for something.
Definitely not needed, I think the jq based script ignores it or I was lazy about clearing it. |
Fixes #333
Allows step to be None