Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: make_current is deprecated #3885

Closed
hoxbro opened this issue Sep 26, 2022 · 3 comments · Fixed by #4506
Closed

DeprecationWarning: make_current is deprecated #3885

hoxbro opened this issue Sep 26, 2022 · 3 comments · Fixed by #4506
Assignees
Milestone

Comments

@hoxbro
Copy link
Member

hoxbro commented Sep 26, 2022

Seeing a lot of these warnings in the test suite.

  /usr/share/miniconda3/envs/test-environment/lib/python3.9/site-packages/tornado/ioloop.py:350: DeprecationWarning: make_current is deprecated; start the event loop first
    self.make_current()
@hoxbro hoxbro added the TRIAGE Default label for untriaged issues label Sep 26, 2022
@philippjfr
Copy link
Member

This isn't our fault, Tornado added the deprecation but did not remove all calls to make_current from their codebase:

https://github.com/tornadoweb/tornado/blob/6cfa37ab4e03a7c82bfd2869ce528a452bd521e5/tornado/ioloop.py#L350

@philippjfr philippjfr removed the TRIAGE Default label for untriaged issues label Sep 26, 2022
@hoxbro
Copy link
Member Author

hoxbro commented Sep 26, 2022

What about this one?

loop.make_current()

@philippjfr philippjfr reopened this Sep 26, 2022
@philippjfr
Copy link
Member

Just spotted that too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants