-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PasswordInput widget similar to TextInput #655
Conversation
Thanks for this @julwin. Did you forget to push the new file? |
Hm I don't know tbh - I only modified panel/widgets/input.py. Am I missing something here? |
Ah, nevermind sorry for the confusion, I didn't realize PasswordInput was an existing model in bokeh. I thought you had implemented a custom model in panel. Ignore me :) |
Okay, then the only thing we need before merge is a reference notebook like this one for the TextInput widget. |
I see 😄 It is a pretty small change after all |
@philippjfr thanks - will add the notebook and update. |
Done: examples/reference/widgets/PasswordInput.ipynb |
Sorry should have mentioned this earlier. Please clear the notebook before committing it. |
No worries, makes sense 👍 |
Looks good, one small suggestion. Once you apply it I'll merge. Thanks for contributing! |
Co-Authored-By: Philipp Rudiger <prudiger@anaconda.com>
Thanks, will continue to do so. It's a great project 😎 |
Added a PasswordInput widget using the Bokeh widget PasswordInput. Did not add to documentation or tests as of now.