Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline network diagram should be clickable #734

Closed
1 task
jbednar opened this issue Oct 31, 2019 · 0 comments · Fixed by #770
Closed
1 task

Pipeline network diagram should be clickable #734

jbednar opened this issue Oct 31, 2019 · 0 comments · Fixed by #770
Assignees
Labels
type: bug Something isn't correct or isn't working type: enhancement Minor feature or improvement to an existing feature

Comments

@jbednar
Copy link
Member

jbednar commented Oct 31, 2019

At some point, the nodes in the pipeline layout diagram were clickable, selecting that stage.

image

Hover currently (in Panel and HoloViews master) works for the nodes, but clicking doesn't do anything. I think that clicking should be supported in at least the following cases:

  • clicking on the previous and next nodes should work precisely the same as clicking on the Previous and Next buttons. Clicking on the diagram is a very clear way for a user to unambiguously select a stage, and supporting that also lets a panel designer suppress those buttons to save screen real estate without losing any functionality.
  • Clicking on arbitrary stages should also be supported, if one could already just click forward or back to get there, and it should have the same semantics as doing so (being supported in all the same cases and having the same effect).
  • Clicking on the start node should always be supported, even for a Pipeline that defines a ready_parameter, with results equivalent to reloading the page if moving backwards to that node is not otherwise allowed using the Previous button. I.e., it always makes sense to start completely over (right?), given that a user can already reload the page, so I think the diagram should allow that behavior. Otherwise it's frustrating for users -- they can see what they want to do, but no way to make the pipeline do it, even when what they want to do is inherently appropriate and reasonable.
@jbednar jbednar added the TRIAGE Default label for untriaged issues label Oct 31, 2019
@jbednar jbednar added type: bug Something isn't correct or isn't working type: enhancement Minor feature or improvement to an existing feature and removed TRIAGE Default label for untriaged issues labels Nov 1, 2019
@philippjfr philippjfr mentioned this issue Nov 1, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants