Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log authorization callback errors #7463

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix: Log authorization callback errors #7463

merged 3 commits into from
Nov 6, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 5, 2024

So a warning is emitted if something goes wrong in the authentication callback.

Also, set the status code if no auth fails to 403.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.30%. Comparing base (c06f779) to head (c3b3f8c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/server.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7463   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         338      338           
  Lines       50819    50838   +19     
=======================================
+ Hits        41825    41843   +18     
- Misses       8994     8995    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro changed the title fix: Log auth errors fix: Log authorization callback errors Nov 5, 2024
@hoxbro hoxbro marked this pull request as ready for review November 5, 2024 16:18
@hoxbro hoxbro requested a review from philippjfr November 5, 2024 17:20
@philippjfr philippjfr merged commit 6c322c5 into main Nov 6, 2024
18 checks passed
@philippjfr philippjfr deleted the fix_auth_error branch November 6, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants