Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google photos offiall vs unofficial #126808

Closed
LukaszP2 opened this issue Sep 26, 2024 · 10 comments
Closed

Google photos offiall vs unofficial #126808

LukaszP2 opened this issue Sep 26, 2024 · 10 comments

Comments

@LukaszP2
Copy link

LukaszP2 commented Sep 26, 2024

The problem

I use https://github.com/daanoz/ha-google-photos
I can't use officiall integration.

What version of Home Assistant Core has the issue?

core-2024.10.0b0

What was the last working version of Home Assistant Core?

core-2024.9.3

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Google photos

Link to integration documentation on our website

https://rc.home-assistant.io/integrations/google_photos

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @allenporter, mind taking a look at this issue as it has been labeled with an integration (google_photos) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_photos can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign google_photos Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


google_photos documentation
google_photos source
(message by IssueLinks)

@joostlek
Copy link
Member

I am not sure what your question is? They're both different integrations with different functionality. The functionality in the old integration is deprecated by Google.

@LukaszP2
Copy link
Author

@joostlek
Copy link
Member

Yes that's how this works, a custom component has preference over a core one when they share the same domain. This is not a bug.

@LukaszP2
Copy link
Author

But you say: "different functionality". So why thay have same domain?

@joostlek
Copy link
Member

Because custom components can't "reserve" a domain. Core is leading with domains and if a domain is taken I guess the custom one has to rename.

@dshokouhi
Copy link
Member

yup you are allowed to drop in a full replacement for a HA core integration by it keeping the same domain name. To avoid that the custom integration needs to change its name completely. That is the responsibility of the custom integration.

@allenporter allenporter closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
@Daanoz
Copy link

Daanoz commented Sep 28, 2024

(Author of the custom integration here) For anyone else arriving here, due to the API changes announced by Google, I'll be deprecating / archiving the custom integration on April 2025 as it doesn't make a lot of sense to me that the integration can only access photo's it uploaded itself. See Daanoz/ha-google-photos#64.

I would recommend switching to the core integration if you want to keep integrating with Google Photos.

@joostlek
Copy link
Member

@Daanoz Thanks for maintaining this integration for a long time by the way ❤️. At least there's now a migration path possible for the full duration of the deprecation at Google.

If you however think you can improve something to the core version, feel free to open a PR or hmu on Discord because I love to speak to HA Devs and what thrives them :)

@Daanoz
Copy link

Daanoz commented Sep 28, 2024

Yeah, that's a lucky coincidence :).

I'll have a look once I migrate my own setup to the new integration after 2024.10 is released. I'm already lurking on the Discord, I'll be sure to check-in if I find something.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants