Initial import for HassIO #6935

pvizeli · 2017-04-04T15:31:11Z

Description:

The next generation of IoT device is comming, HassIO. It provide image for most of avilable IoT hardware and make this device maintenance free and easy to use. It is the first private cloud home solution for HomeAssistant and abstract IoT to a new Level with virtualisation. On this place a big thanks to Resin Team.

HassIO become a full UI Integration into hass and make Hardware and HomeAssistant to one peace. At the moment it is not for production use!

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

balloob · 2017-04-05T16:22:41Z

homeassistant/components/hassio.py

+        DOMAIN, SERVICE_ADDON_UNINSTALL,
+        descriptions[DOMAIN][SERVICE_ADDON_UNINSTALL],
+        schema=SCHEMA_SERVICE_ADDONS)
+    hass.services.async_register(


I wonder if services is the right way to expose management of the system. The alternative is an API that we call from a specialized frontend panel. The nice thing about API is that we can have return values and know if a service was a success etc.

We have no access from outside to supervisor. I think that is the best thing for security. So we need passtrough this stuff over hass.

I design the thing in the way that we call /xy/info with config pannel to load data and send it to frontend. So we need only call this getter (like the code from hassbian config) to rebuild infos after service call.

MartinHjelmare · 2017-04-05T23:19:23Z

homeassistant/components/hassio.py

+    @asyncio.coroutine
+    def async_service_handler(service):
+        """Handle HassIO service calls."""
+        if service.service == SERVICE_HOST_UPDATE:


I suggest you create a dict that maps services to commands, payloads and schemas and lookup that here. See cover component for example. It will use a lot fewer lines of code.

MartinHjelmare · 2017-04-06T11:28:36Z

homeassistant/components/hassio.py

+            yield from hassio.send_command("/addons/{}/stop".format(addon))
+        elif service.service == SERVICE_ADDON_UPDATE:
+            yield from hassio.send_command(
+                "/addons/{}/update".format(addon), payload=version)


If you make SERVICE_MAP nested you could include a key-pair for the command string and another key-pair for the payload. Then have two cases at lookup-time, ie here, one where addon is None which just passes the command string to the send_command method and another case where addon is not None which uses string formatting on the command string before passing it along.

You would not need this long if - else trail.

I think we can do that later. for the moment it help for more readable of code and maby we change some things in next version. That is also the reason of v1 on name :)

pvizeli · 2017-04-06T15:32:45Z

Ready to merge 💃

balloob · 2017-04-06T15:50:57Z

homeassistant/components/hassio.py

+        try:
+            with async_timeout.timeout(TIMEOUT, loop=self.loop):
+                request = yield from self.websession.get(
+                    "http://{}{}".format(self._ip, cmd),


What if self._ip is None, this will return an error?

Resolving IP should also happen inside setup, as it's a Home Assistant concern where it comes from.

We can do that. But without IP it will not load the component

balloob · 2017-04-06T15:53:53Z

homeassistant/components/hassio.py

+    @asyncio.coroutine
+    def post(self, request, addon):
+        """Set options on host."""
+        data = yield from request.json()


We should have voluptuous schemas for data. That way any vulnerability in hassio won't be exposed.

I think we make only a passthrought. HassIO will give a error back to frontend if a option will not support it.

balloob · 2017-04-06T15:55:03Z

homeassistant/components/hassio.py

+    @asyncio.coroutine
+    def get(self, request):
+        """Get base data."""
+        data = yield from self.hassio.send_command(self._url_info)


Should we wrap these in async_timeout ?

We do that on HassIO object

balloob · 2017-04-06T16:04:35Z

tests/test_util/aiohttp.py

        """Match a request against pre-registered requests."""
+        data = data or json


We should make sure the json is converted to a string and stored in data. That way we can match the string data = "{}" against json = {} (as the requests are the same)

That make it bad for tests... I need revert it on every test case. That will be nonsense

At the end we use that only inside tests, If possible that we have that test friendly?

oh good point, I thought it was used for matching. This is ok.

balloob · 2017-04-06T16:05:21Z

homeassistant/components/hassio.py

+
+_LOGGER = logging.getLogger(__name__)
+
+TIMEOUT = 900


Why is this timeout so high?

A docker image can have a long time to pull

balloob · 2017-04-06T16:08:14Z

homeassistant/components/hassio.py

+    @property
+    def connected(self):
+        """Return True if it connected to HassIO supervisor."""
+        return self._ip is not None


Should there be a no-op API command so that we can connect to HASSIO and verify that we can make a connection? We do something similar for our normal API https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/remote.py#L81-L86

* Initial import for HassIO * Cleanup api code for views * First unittest for view * Add test for edit view * Finish unittest * fix addons test * cleanup service.yaml * Address first round with ping command * handle timeout dynamic * fix lint

balloob · 2017-04-08T11:56:09Z

Cherry-picked into the 0.42 branch

homeassistant added new-platform integration: hassio cla-signed labels Apr 4, 2017

balloob reviewed Apr 5, 2017

View reviewed changes

pvizeli changed the title ~~[WIP] Initial import for HassIO~~ Initial import for HassIO Apr 5, 2017

homeassistant added the cla-signed label Apr 5, 2017

balloobbot added the component label Apr 5, 2017

MartinHjelmare reviewed Apr 5, 2017

View reviewed changes

homeassistant added the cla-signed label Apr 6, 2017

MartinHjelmare reviewed Apr 6, 2017

View reviewed changes

pvizeli added 3 commits April 6, 2017 15:48

Initial import for HassIO

72a6bc2

Cleanup api code for views

7bb1570

First unittest for view

2999a36

pvizeli force-pushed the hassio_v1 branch from c8735f6 to 2999a36 Compare April 6, 2017 13:50

homeassistant added the cla-signed label Apr 6, 2017

pvizeli added 2 commits April 6, 2017 17:16

Add test for edit view

51079ab

Finish unittest

138915b

pvizeli force-pushed the hassio_v1 branch from 66cf72e to 138915b Compare April 6, 2017 15:17

homeassistant added the cla-signed label Apr 6, 2017

fix addons test

ce3fdf2

cleanup service.yaml

9b4f9b7

balloob added this to the 0.42 milestone Apr 6, 2017

balloob requested changes Apr 6, 2017

View reviewed changes

Address first round with ping command

aff2801

homeassistant added the cla-signed label Apr 6, 2017

pvizeli added 2 commits April 6, 2017 22:33

handle timeout dynamic

c6bd910

fix lint

10e7f3c

balloob approved these changes Apr 7, 2017

View reviewed changes

balloob merged commit 3e66df5 into home-assistant:dev Apr 7, 2017

fabaff mentioned this pull request Apr 8, 2017

0.42 #6956

Merged

balloob mentioned this pull request Apr 21, 2017

0.43 #7197

Merged

home-assistant locked and limited conversation to collaborators Jul 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial import for HassIO #6935

Initial import for HassIO #6935

pvizeli commented Apr 4, 2017 •

edited

Loading

balloob Apr 5, 2017

pvizeli Apr 5, 2017 •

edited

Loading

MartinHjelmare Apr 5, 2017

pvizeli Apr 6, 2017

MartinHjelmare Apr 6, 2017

pvizeli Apr 6, 2017 •

edited

Loading

pvizeli commented Apr 6, 2017

balloob Apr 6, 2017

balloob Apr 6, 2017

pvizeli Apr 6, 2017

pvizeli Apr 6, 2017

balloob Apr 6, 2017

pvizeli Apr 6, 2017

balloob Apr 6, 2017

pvizeli Apr 6, 2017

balloob Apr 6, 2017

pvizeli Apr 6, 2017

pvizeli Apr 6, 2017

balloob Apr 7, 2017

balloob Apr 6, 2017

pvizeli Apr 6, 2017

balloob Apr 6, 2017

pvizeli Apr 6, 2017

balloob commented Apr 8, 2017

		"""Match a request against pre-registered requests."""
		data = data or json


		_LOGGER = logging.getLogger(__name__)

		TIMEOUT = 900

Initial import for HassIO #6935

Initial import for HassIO #6935

Conversation

pvizeli commented Apr 4, 2017 • edited Loading

Description:

Choose a reason for hiding this comment

pvizeli Apr 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pvizeli Apr 6, 2017 • edited Loading

Choose a reason for hiding this comment

pvizeli commented Apr 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balloob commented Apr 8, 2017

pvizeli commented Apr 4, 2017 •

edited

Loading

pvizeli Apr 5, 2017 •

edited

Loading

pvizeli Apr 6, 2017 •

edited

Loading