Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Thermostat PID controller configuration values HVAC mode independent #299

Open
climategadgets opened this issue Nov 27, 2023 · 0 comments

Comments

@climategadgets
Copy link
Member

climategadgets commented Nov 27, 2023

Existing Behavior

PID controller p and i values must be positive for cooling mode and negative for heating. This requires two changes in unrelated configuration sections to change the operating mode. Moreover, economizer configuration already allows keeping the same PID values for cooling and heating operation, thus confusing things even more.

Desired Behavior

Virtual thermostat recognizes the operating mode and allows to use the same values for both cooling and heating mode.

Implementation Considerations

As of v4.3.0, Mode is specified in three configurations: Zone (implicitly with PID controller p and i values sign), Switchable HVAC device (explicitly), and Director (explicitly).

  • Switchable HVAC device simply turns on and off depending on demand generated, its mode can't be changed because it's determined by physics (it is either a cooler or a heater).
  • Director prepends the mode command to the command stream sent to the HVAC device (any, not just Switchable).
  • Zone generates the demand value matching the HVAC device mode.

The key to solving this problem is to detect the mode at Zone creation time, and provide correct values to its PID controller. Providing mode to the Zone is cumbersome, so it looks like the Zones need to be created by the Director (instead of directly as they are now).

Alternatively, an arguably less elegant but more future proof solution (automatic changeover is coming someday, right?) would be to allow setting a Zone mode directly and reconfiguring the PID controller on the fly - in this case the mode will have to be sent to the zones just as it is being sent to the HVAC device.

@climategadgets climategadgets changed the title Make PID controller configuration values HVAC mode independent Make Thermostat PID controller configuration values HVAC mode independent Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant