Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclickable checkboxes with static configuration schemas #2200

Closed
thoukydides opened this issue Oct 9, 2024 · 3 comments
Closed

Unclickable checkboxes with static configuration schemas #2200

thoukydides opened this issue Oct 9, 2024 · 3 comments
Labels

Comments

@thoukydides
Copy link

Describe The Bug

Checkbox inputs are not displaying correctly with static configuration schemas. This is an example from homebridge-aeg-robot:

image

It corresponds to this part of the config.schema.json:

{
    "schema": {
        "type": "object",
        "properties": {
            "hideServices": {
                "type": "array",
                "uniqueItems": true,
                "items": {
                    "type": "string",
                    "enum": [
                        "Battery",
                        "Contact Sensor",
                        "Fan",
                        "Filter Maintenance",
                        "Occupancy Sensor",
                        "Switch Clean",
                        "Switch Home"
                    ]
                }
            }
        }
    },
    "form": [{
        "type": "fieldset",
        "title": "Disable Unwanted Features",
        "expandable": false,
        "expanded": true,
        "items": [{
            "key": "hideServices",
            "notitle": true,
            "description": "Checking an option <b>disables</b> the corresponding HomeKit Service"
        }]
    }]
}

The selected items are clearly not being styled appropriately. However, more serious, is that the selected items can be deselected, but clicks on the deselected items do nothing.

Custom UI checkbox inputs still work correctly; this only appears to affect static config.schema.json usage. I have seen the same with other plugins that use static configuration schemas, such as homebridge-weather-plus.

This was first raised as thoukydides/homebridge-aeg-robot#54.

Logs

No response

Config

No response

Homebridge UI Version

4.60.1

Homebridge Version

1.8.4

Node.js Version

18.20.4

Operating System

Ubuntu / Debian (or a variant)

Environment Info

Using systemd

Raspberry Pi Model

None

@thoukydides thoukydides added the bug label Oct 9, 2024
@thoukydides thoukydides changed the title Unclickable Unclickable checkboxes with static configuration schemas Oct 9, 2024
@bwp91
Copy link
Contributor

bwp91 commented Oct 9, 2024

Hi @thoukydides

Thanks for reporting this issue, I believe I have managed to fix this in a beta version of the UI that has been published a few minutes ago.

Would you be able to install and confirm?

@thoukydides
Copy link
Author

I have just tested 4.60.2-beta.1 and it fixes the problem for all of the plugins I use, so looks good to me.

Thank you for fixing it so quickly.

@bwp91
Copy link
Contributor

bwp91 commented Oct 12, 2024

Fixed in latest version 👍, thanks again for the report

@bwp91 bwp91 closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants