Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we load plugins when using multiple clients? #1181

Open
BethanyBerkowitz opened this issue Sep 6, 2023 · 0 comments
Open

Should we load plugins when using multiple clients? #1181

BethanyBerkowitz opened this issue Sep 6, 2023 · 0 comments
Labels
js @honeybadger-io/js

Comments

@BethanyBerkowitz
Copy link
Contributor

See #1172 (comment)

Our browser and server clients have a factory() method to create a second instance of the client. This can be used if a project needs to report to multiple HB projects, for example.

However, when creating a new client, we don't include the plugins that were present in the initial client. This could be confusing because, for example, the original client will report uncaught errors and the clone will not because it doesn't have the uncaught exception plugin.

Our existing plugins for uncaught exception and unhandled rejection are not necessarily designed to be loaded in two separate clients -- if we decide we want to load the plugins in the secondary client(s), we should do some careful review of the code and testing to make sure that the plugins will function correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
js @honeybadger-io/js
Projects
None yet
Development

No branches or pull requests

1 participant