Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Node.js-patching libraries #843

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Jul 23, 2022

Workaround for #825

Copy link
Member

@subzero10 subzero10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks harmless 😅

@shalvah shalvah merged commit d6a1542 into master Jul 25, 2022
@shalvah shalvah deleted the nodejs-patching-fix branch July 25, 2022 16:22
@subzero10
Copy link
Member

@shipjs prepare

@github-actions
Copy link
Contributor

@subzero10 shipjs prepare done

@subzero10
Copy link
Member

@shalvah I cannot release a new version with this PR because it does not follow conventional commits syntax and therefore it picked up nothing to release:

› Calculating the next version.
The following commit messages out of convention are ignored:
  Merge pull request #843 from honeybadger-io/nodejs-patching-fix
  Workaround for Node.js-patching libraries
› Confirming the next version.
The current version: 4.0.4
The next version: 4.0.5
› Validating preparation conditions.
`shouldPrepare` returned false. So the preparation is skipped.

Did you not receive an error when trying to commit from your local environment? Or did you disable git hooks?
(note for me: update this section to inform about commit syntax)

I will publish a new version when this is merged.

@shalvah
Copy link
Contributor Author

shalvah commented Jul 26, 2022

I cannot release a new version with this PR because it does not follow conventional commits syntax and therefore it picked up nothing to release

Isn't there a way to override it? Seems like a flaw if that can't be overridden.

Did you not receive an error when trying to commit from your local environment

The other one did; this didn't.

@subzero10
Copy link
Member

I cannot release a new version with this PR because it does not follow conventional commits syntax and therefore it picked up nothing to release

Isn't there a way to override it? Seems like a flaw if that can't be overridden.

Not from what I know. And it makes sense, because CHANGELOG is generated from the commits so they must follow the syntax. The workaround would be to push another dummy commit (new PR) with the right syntax.

Did you not receive an error when trying to commit from your local environment

The other one did; this didn't.

This is strange. Did you pull latest before creating this branch?

@subzero10
Copy link
Member

The workaround would be to push another dummy commit (new PR) with the right syntax.

I will do this now so we can proceed with the release.

subzero10 added a commit that referenced this pull request Jul 26, 2022
@subzero10
Copy link
Member

@shipjs prepare

@github-actions
Copy link
Contributor

@subzero10 shipjs prepare done

@subzero10
Copy link
Member

Done! Released v4.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants