-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for Node.js-patching libraries #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks harmless 😅
@shipjs prepare |
@subzero10 |
@shalvah I cannot release a new version with this PR because it does not follow conventional commits syntax and therefore it picked up nothing to release:
Did you not receive an error when trying to commit from your local environment? Or did you disable git hooks? I will publish a new version when this is merged. |
Isn't there a way to override it? Seems like a flaw if that can't be overridden.
The other one did; this didn't. |
Not from what I know. And it makes sense, because CHANGELOG is generated from the commits so they must follow the syntax. The workaround would be to push another dummy commit (new PR) with the right syntax.
This is strange. Did you pull latest before creating this branch? |
I will do this now so we can proceed with the release. |
@shipjs prepare |
@subzero10 |
Done! Released |
Workaround for #825