chore: notice.causes refactor
#854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @shalvah, while I was merging master to the monorepo branch, I realized that I could move |
|
Yeah, that would work. |
subzero10
added a commit
that referenced
this pull request
Aug 12, 2022
) * feat(monorepo): setup monorepo skeleton and break js package to 2 packages * chore(monorepo): fix test scripts * chore(monorepo): fix test scripts * chore(monorepo): rollup config * chore(monorepo): remove ie11 from integration testing Refs: https://blogs.windows.com/windowsexperience/2022/06/15/internet-explorer-11-has-retired-and-is-officially-out-of-support-what-you-need-to-know/ * chore(monorepo): set org name to hb-test (temporarily) * chore(monorepo): bump to v4.0.5 to match master * chore(monorepo): generate changelog files * chore(monorepo): publish without asking * chore(monorepo): publish config => public * chore(monorepo): revert test org name * chore(monorepo): add readme files * chore(monorepo): core readme file * chore(monorepo): modify readme * chore(monorepo): improve ts build * chore(monorepo): fix tsd * Update README.md * chore: remove eslint comment * docs: make README clearer * chore: refactor causes out of notice class (#854) Co-authored-by: Joshua Wood <josh@joshuawood.net> Co-authored-by: shalvah <diakon.ng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Refactor
notice.causesoutside theNoticetype, since it's only used when sending the payload to Honeybadger.Todos