Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: README.md misleading dev to use wrong import code on while working with ES6 Import. #916

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

ecarrizo2
Copy link
Contributor

@ecarrizo2 ecarrizo2 commented Oct 20, 2022

Context:
import * as HoneyBadger from '@honeybadger-io/js' as indicated in the documentation using nodejs + TypeScript results in errors such as 'configure' is not a function.

What really works in a nodejs + TypeScript context is using:
import HoneyBadger from '@honeybadger-io/js'

Status

READY

Description

A Change in the README.MD file to make it clear which is the right import statement to use while using ES6 imports + TypeScript

Todos

  • Changelog Entry (unreleased)

Context: 
`Import * as HoneyBadger from '@honeybadger-io/js' results in errors such as 'configure' is not a function.

What really works in a nodejs context is using
`import HoneyBadger from '@honeybadger-io/js'`
@subzero10 subzero10 changed the title Fix: README.md misleading dev to use wrong import code on while working with ES6 Import. fix: README.md misleading dev to use wrong import code on while working with ES6 Import. Oct 21, 2022
@subzero10
Copy link
Member

Thank you @ecarrizo2!

@subzero10 subzero10 merged commit 246633a into honeybadger-io:master Oct 21, 2022
@ecarrizo2 ecarrizo2 deleted the patch-1 branch October 21, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants