fix: filter out honeybadger source code from stack trace #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subzero10
commented
Dec 16, 2022
stympy
previously approved these changes
Dec 16, 2022
shalvah
reviewed
Dec 16, 2022
packages/core/src/util.ts
Outdated
| continue | ||
| } | ||
|
|
||
| if (frame.file || frame.file === '<anonymous>') { |
There was a problem hiding this comment.
What's the scenario where a frame's file is <Anonymous>? THat's missing in the (very good) explanation.
There was a problem hiding this comment.
Your comment saved me! I missed a negation (it should be if (!frame.file ...).
To answer your question, this came up from the fault I was debugging. I don't know when it happens, but I know it can happen. That's why I came up with the [not-so-straight-forward] approach to ignore these frames if they happen to be in-between our source code. Otherwise, the algorithm would stop here and would not see that the next frame is still honeybadger source code.
See attached image.
subzero10
force-pushed
the
broken_grouping_#979
branch
from
9fa8df1
to
98a2b50
Compare
|
@BethanyBerkowitz All review feedback applied. I've just requested another round of review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes: #979
Todos