feat: add aggregated metrics for rails and more #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds aggregated metrics for the following plugins: * rails * net_http * sidekiq Similar to the Karafka plugin, there is now more configuration: * `rails.insights.events` * `rails.insights.metrics` * `sidekiq.insights.events` * `sidekiq.insights.metrics` * `net_http.insights.events` * `net_http.insights.metrics`
roelbondoc
force-pushed
the
add-more-aggregated-metrics
branch
from
7a6c8f7 to
bc87b48
Compare
stympy
requested changes
Nov 7, 2024
Comment on lines
64
to
68
| def find_metrics(name, payload) | ||
| RAILS_METRICS.select do |metric| | ||
| metric.event.to_s == name.to_s && payload.keys.include?(metric.value_key) && (payload.keys & metric.context).any? | ||
| end | ||
| end |
There was a problem hiding this comment.
I'm nervous about the load that will be added by going through this loop for every event. Perhaps this could be optimized by converting RAILS_METRICS into a hash, keyed by name, and the value is a proc or something callable that accepts the payload and either returns an array of metrics to the caller (like the method currently does) or even calls public_send itself. Maybe that "something callable" is a Metric class that's more than just a struct. :)
stympy
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds aggregated metrics for the following plugins:
Similar to the Karafka plugin, there is now more configuration to fine tune the data:
rails.insights.eventsrails.insights.metricssidekiq.insights.eventssidekiq.insights.metricsnet_http.insights.eventsnet_http.insights.metricsBefore submitting a pull request, please make sure the following is done:
rake specin the repository root.