fix: Use AWS::Partition Pseudo Parameter in IAM ARNs #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In AWS GovCloud, the RDS and CloudWatch Logs templates fail because the RDS and CloudWatch Logs templates contain IAM ARNs hardcoded with the AWS commercial partition (aws) instead of (aws-us-gov).
Example Error Message:
This PR is a copy of #37 but under Honeycomb's repository because of permissions issues
Short description of the changes
Swap the hardcoded AWS partition with the AWS Partition Pseudo Parameter,
AWS::Partition
Allow CloudWatch Logs service in non-default AWS Partitions to assume LogStreamRole
For RDS Logs TransformLambdaRole, use correct AWSLambdaBasicExecutionRole ARN for non-default AWS Partitions
How to verify that this has the expected result
Deploy RDS Logs or CloudWatch Logs templates in AWS GovCloud.