ci: simplify dev/CI and prepare for image building #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use a LinuxServer.io[1] image for yq/jq to avoid managing a whole Python install * added scripts to a new ./bin directory to simplify the running of yq/jq * use Make to retrieve the necessary version of Collector to build upon; yq to query the version of the Collector in builder-config so that the version is declared in one place [1] https://hub.docker.com/r/linuxserver/yq
While go-yq *is* available in the CI runner, we need python-yq to
support defining functions in jq-programs and some other specific
syntax currently in use.
Update the bin/{jq|yq} wrappers to use local binaries on PATH if they
exist. In yq's case, also check that it is the python edition.
... because it didn't work, back to python-yq with a Python install.
We will need to do this in any new jobs added to get the right yq.
Doesn't work for things that run Docker-in-Docker with fancy volume mounts, though.
* Declare that name in Makefile and builder-config * some more nuanced version determination in Make, too * generate code into a directory that looks like other Go projects: cmd/<command name> * add some judicious commentary to target outputs
The time of a directory is unreliable for determining need to rebuild.
maybe it works in CI?
robbkidd
force-pushed
the
robb.ci-shenanigans
branch
from
c324e8b to
249ad86
Compare
This uses possibly-too-much Make to derive binary names from a list of OS/CPUs.
robbkidd
force-pushed
the
robb.ci-shenanigans
branch
from
55db64a to
f9b9713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overhaul ocb, jq, and yq prereqs
something something image publish