Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify boilarplate doesnt comes up with package.json #2882

Closed
xkeshav opened this issue Jun 1, 2024 · 4 comments
Closed

netlify boilarplate doesnt comes up with package.json #2882

xkeshav opened this issue Jun 1, 2024 · 4 comments

Comments

@xkeshav
Copy link

xkeshav commented Jun 1, 2024

What version of Hono are you using?

4.0.9

What runtime/platform is your app running on?

Netlify

What steps can reproduce the bug?

try to install new app using hono

npm create hono@latest my-app

but in local I cant run it , also see there are import statment in edge_functsions/index.ts

import { Hono } from 'jsr:@hono/hono'
import { handle } from 'jsr:@hono/hono/netlify'

const app = new Hono()

app.get('/', (c) => {
  return c.text('Hello Hono!')
})

export default handle(app)

but didnt see any package.json?

Am i Missing something?

although netlify dev runs great

What is the expected behavior?

there must be package.json so that we can run command and add other features

What do you see instead?

No response

Additional information

running on Ubuntu 24.04 and having netlify CLI insatted and logged in

@xkeshav xkeshav added the bug label Jun 1, 2024
@EdamAme-x
Copy link
Contributor

EdamAme-x commented Jun 1, 2024

hi @xkeshav.
I think that this problem related to honojs/starter

@NicoPlyley
Copy link
Contributor

Hi @xkeshav,
As mentioned this would be on honojs/starter. However, I don't believe Netlify uses a package.json. They run their edge functions with Deno and to my understanding using jsr:@hono/hono is all that is needed to "install" packages, the rest of the settings would be in the netlify.toml file.

@yusukebe
Copy link
Member

yusukebe commented Jun 5, 2024

@xkeshav

As you mentioned above, you don't need to install any npm packages. And, there is a bug that create-hono will run npm install for Nextlify, but it was solved with honojs/create-hono#41.

@yusukebe yusukebe removed the bug label Jun 5, 2024
@yusukebe
Copy link
Member

I think we can close this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants