From de2e95a59e4c02b9e985f9e3f81792b7890c922d Mon Sep 17 00:00:00 2001 From: Yusuke Wada Date: Wed, 23 Aug 2023 10:57:54 +0900 Subject: [PATCH] fix(sentry): fixed sentry options types (#130) * fix(sentry): fixed sentry options types * changeset --- .changeset/strong-hotels-kiss.md | 5 +++++ packages/sentry/deno_dist/index.ts | 15 +++------------ packages/sentry/src/index.ts | 15 +++------------ packages/sentry/src/replacer.ts | 2 +- packages/sentry/test/index.test.ts | 1 + 5 files changed, 13 insertions(+), 25 deletions(-) create mode 100644 .changeset/strong-hotels-kiss.md diff --git a/.changeset/strong-hotels-kiss.md b/.changeset/strong-hotels-kiss.md new file mode 100644 index 00000000..21d66d1a --- /dev/null +++ b/.changeset/strong-hotels-kiss.md @@ -0,0 +1,5 @@ +--- +'@hono/sentry': patch +--- + +fixed sentry options types diff --git a/packages/sentry/deno_dist/index.ts b/packages/sentry/deno_dist/index.ts index a3d740f0..2b10fa8d 100644 --- a/packages/sentry/deno_dist/index.ts +++ b/packages/sentry/deno_dist/index.ts @@ -1,5 +1,6 @@ import type { Context, MiddlewareHandler } from 'https://deno.land/x/hono/mod.ts' import Toucan from 'https://cdn.skypack.dev/toucan-js@2.7.0' +import type { Options as ToucanOptions } from 'https://cdn.skypack.dev/toucan-js@2.7.0' declare module 'https://deno.land/x/hono/mod.ts' { interface ContextVariableMap { @@ -11,23 +12,13 @@ class MockContext implements ExecutionContext { passThroughOnException(): void { throw new Error('Method not implemented.') } + // eslint-disable-next-line @typescript-eslint/no-explicit-any async waitUntil(promise: Promise): Promise { await promise } } -export type Options = { - dsn?: string - allowedCookies?: string[] | RegExp - allowedHeaders?: string[] | RegExp - allowedSearchParams?: string[] | RegExp - attachStacktrace?: boolean - debug?: boolean - environment?: string - maxBreadcrumbs?: number - pkg?: Record - release?: string -} +export type Options = Omit export const sentry = ( options?: Options, diff --git a/packages/sentry/src/index.ts b/packages/sentry/src/index.ts index 82396b08..dfa91f63 100644 --- a/packages/sentry/src/index.ts +++ b/packages/sentry/src/index.ts @@ -1,5 +1,6 @@ import type { Context, MiddlewareHandler } from 'hono' import Toucan from 'toucan-js' +import type { Options as ToucanOptions } from 'toucan-js' declare module 'hono' { interface ContextVariableMap { @@ -11,23 +12,13 @@ class MockContext implements ExecutionContext { passThroughOnException(): void { throw new Error('Method not implemented.') } + // eslint-disable-next-line @typescript-eslint/no-explicit-any async waitUntil(promise: Promise): Promise { await promise } } -export type Options = { - dsn?: string - allowedCookies?: string[] | RegExp - allowedHeaders?: string[] | RegExp - allowedSearchParams?: string[] | RegExp - attachStacktrace?: boolean - debug?: boolean - environment?: string - maxBreadcrumbs?: number - pkg?: Record - release?: string -} +export type Options = Omit export const sentry = ( options?: Options, diff --git a/packages/sentry/src/replacer.ts b/packages/sentry/src/replacer.ts index a75f8cf5..765feabe 100644 --- a/packages/sentry/src/replacer.ts +++ b/packages/sentry/src/replacer.ts @@ -17,7 +17,7 @@ makeThisModuleAnExecutableReplacer(async ({ parsedImportExportStatement, version ...parsedImportExportStatement, parsedArgument: { type: 'URL', - url: `https://deno.land/x/hono/mod.ts`, + url: 'https://deno.land/x/hono/mod.ts', }, }) } diff --git a/packages/sentry/test/index.test.ts b/packages/sentry/test/index.test.ts index c2174c00..861dbfb7 100644 --- a/packages/sentry/test/index.test.ts +++ b/packages/sentry/test/index.test.ts @@ -6,6 +6,7 @@ class Context implements ExecutionContext { passThroughOnException(): void { throw new Error('Method not implemented.') } + // eslint-disable-next-line @typescript-eslint/no-explicit-any async waitUntil(promise: Promise): Promise { await promise }