Dispatch visit events on form elements

hotwired · Sep 21, 2023 · 547f0c7 · 547f0c7
1 parent 7a5dfd6
commit 547f0c7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/core/drive/navigator.js b/src/core/drive/navigator.js
@@ -85,6 +85,7 @@ export class Navigator {
         const { statusCode, redirected } = fetchResponse
         const action = this.getActionForFormSubmission(formSubmission)
         const visitOptions = {
+          initiator: formSubmission.formElement,
           action,
           shouldCacheSnapshot,
           response: { statusCode, responseHTML, redirected }

diff --git a/src/tests/functional/navigation_tests.js b/src/tests/functional/navigation_tests.js
@@ -494,14 +494,26 @@ test("test ignores forms with a [target] attribute that target an iframe with [n
   assert.equal(pathname(page.url()), "/src/tests/fixtures/one.html")
 })
 
-test("test visit events are dispatched on the initiator", async ({ page }) => {
+test("test visit events are dispatched on links", async ({ page }) => {
   await page.click("#same-origin-unannotated-link")
   await nextEventOnTarget(page, "same-origin-unannotated-link", "turbo:before-visit")
   await nextEventOnTarget(page, "same-origin-unannotated-link", "turbo:visit")
 })
 
-test("test fetch events are dispatched on the initiator", async ({ page }) => {
+test("test visit events are dispatched on forms", async ({ page }) => {
+  await page.click("#same-origin-unannotated-form button")
+  await nextEventOnTarget(page, "same-origin-unannotated-form", "turbo:before-visit")
+  await nextEventOnTarget(page, "same-origin-unannotated-form", "turbo:visit")
+})
+
+test("test fetch events are dispatched on links", async ({ page }) => {
   await page.click("#same-origin-unannotated-link")
   await nextEventOnTarget(page, "same-origin-unannotated-link", "turbo:before-fetch-request")
   await nextEventOnTarget(page, "same-origin-unannotated-link", "turbo:before-fetch-response")
 })
+
+test("test fetch events are dispatched on forms", async ({ page }) => {
+  await page.click("#same-origin-unannotated-form button")
+  await nextEventOnTarget(page, "same-origin-unannotated-form", "turbo:before-fetch-request")
+  await nextEventOnTarget(page, "same-origin-unannotated-form", "turbo:before-fetch-response")
+})