Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for statusMessage #84

Merged
merged 1 commit into from
Feb 12, 2016
Merged

Conversation

catdad
Copy link
Contributor

@catdad catdad commented Jan 20, 2016

#83

Adding statusMessage as per the spec, https://nodejs.org/api/http.html#http_response_statusmessage.

I have an API that requires this value to be set for a bunch of requests. I originally implemented this as a wrapper in my code base, but it really belong in the actual project.

@catdad
Copy link
Contributor Author

catdad commented Jan 20, 2016

I saw that the private _ methods will be deprecated in 2.x, but could not figure out what would be in their place, so I implemented _getStatusMessage to match the methods that exist now. If you prefer a different style, please let me know.

howardabrams added a commit that referenced this pull request Feb 12, 2016
adding support for statusMessage
@howardabrams howardabrams merged commit b069e50 into eugef:master Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants