Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better typings #158

Merged
merged 3 commits into from
Feb 26, 2018
Merged

Better typings #158

merged 3 commits into from
Feb 26, 2018

Conversation

xaralis
Copy link
Contributor

@xaralis xaralis commented Feb 23, 2018

Hello,

this pull requests includes better typings which are more permissive to end user. It covers following scenarios:

  • request object for a controller fn which is typed as extension of express.Request
  • same for Response
  • custom properties appended to request object
  • fixed missing _getRenderView method on Response

@eugef eugef merged commit 2672034 into eugef:master Feb 26, 2018
@eugef
Copy link
Owner

eugef commented Feb 26, 2018

@xaralis thanks for your PR

@xaralis
Copy link
Contributor Author

xaralis commented Feb 26, 2018

@eugef Will you draft out a new release with these changes? It's backwards compatible so it should be totally safe. I would appreciate it.

@eugef
Copy link
Owner

eugef commented Feb 26, 2018

Sure, i 'll ask @howardabrams to do it asap

@howardabrams
Copy link
Collaborator

Done! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xaralis @eugef @howardabrams