Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vectorcall protocol. #389

Closed
fangerer opened this issue Dec 15, 2022 · 0 comments · Fixed by #390
Closed

Add support for vectorcall protocol. #389

fangerer opened this issue Dec 15, 2022 · 0 comments · Fixed by #390
Assignees
Labels
API design enhancement New feature or request HPy update in GraalPy This change requires a related change in GraalPy HPy update in PyPy This change requires a related change in PyPy
Milestone

Comments

@fangerer
Copy link
Contributor

In our Numpy/HPy port we've seen that calling ufunc objects is significantly slower because we don't support the vectorcall protocol. Although HPy's VARARGS calling convention is very similar to the vectorcall calling convention on the receiver side, there is still a big difference on the caller side. In particular, CPython will internally still allocate tuples for arguments and dicts for keyword arguments etc.

Besides that, PEP 590 describes some more shortcomings of the tp_call calling convention.

@fangerer fangerer added this to the ABI version 1 milestone Dec 15, 2022
@fangerer fangerer self-assigned this Dec 15, 2022
@fangerer fangerer added enhancement New feature or request API design HPy update in PyPy This change requires a related change in PyPy HPy update in GraalPy This change requires a related change in GraalPy labels Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API design enhancement New feature or request HPy update in GraalPy This change requires a related change in GraalPy HPy update in PyPy This change requires a related change in PyPy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant